Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with MariaDB when using skipper-deployment.yaml #4779

Closed
david-deck opened this issue Dec 5, 2021 · 3 comments
Closed

Issue with MariaDB when using skipper-deployment.yaml #4779

david-deck opened this issue Dec 5, 2021 · 3 comments
Assignees
Labels
type/bug Is a bug report
Milestone

Comments

@david-deck
Copy link

The "skipper" database is automatically created by an initContainer defined in src/kubernetes/skipper/skipper-deployment.yaml.

      - name: init-mariadb-database
        image: mariadb:10.4.22
        env:
          - name: MARIADB_PWD
            valueFrom:
              secretKeyRef:
                name: mariadb
                key: mariadb-root-password
        command: ['sh', '-c', 'mariadb -h mariadb -u root --password=$MARIADB_PWD -e "CREATE DATABASE IF NOT EXISTS skipper;"']

There is no such initContainer for the mariadb/server database. Thus, Dataflow Server fails to start.

@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Dec 5, 2021
@tzolov
Copy link
Contributor

tzolov commented Dec 6, 2021

Thank you @david-deck ! for the server configuration we don't need to create a database explicitly. Instead the default MariaDB database is used. The problem was that i've wrongly assumed that the default MariaDB database is called mariadb while it is still mysql and messed up an earlier fix for this. Hopefully this last commit dedf069 will solve the issue.

@markpollack markpollack added this to the 2.10.0-RC1 milestone May 17, 2022
@markpollack markpollack added area/documentation Belongs to documentation type/task Something needs to get done and removed status/need-triage Team needs to triage and take a first look area/documentation Belongs to documentation labels May 17, 2022
@markpollack
Copy link
Contributor

We will review the kubernetes files for their usage of mysql and change that to mariadb in the next release since that is the default we are switching to going forward.

@markpollack markpollack changed the title MariaDB Database not created automatically Issue with MariaDB when using skipper-deployment.yaml Oct 7, 2022
@markpollack markpollack added type/bug Is a bug report and removed type/task Something needs to get done labels Oct 7, 2022
@markpollack markpollack modified the milestones: 2.10.0-RC1, 2.10.0 Oct 13, 2022
@corneil
Copy link
Contributor

corneil commented Dec 5, 2022

The files have been updated a while ago.

@corneil corneil closed this as completed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Is a bug report
Projects
None yet
Development

No branches or pull requests

4 participants