Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step execution history is not showing the correct values #4945

Closed
klopfdreh opened this issue Jun 14, 2022 · 8 comments
Closed

Step execution history is not showing the correct values #4945

klopfdreh opened this issue Jun 14, 2022 · 8 comments
Assignees
Labels
area/documentation Belongs to documentation status/need-feedback Calling participant to provide feedback
Milestone

Comments

@klopfdreh
Copy link
Contributor

klopfdreh commented Jun 14, 2022

Hi,

all values in the step execution history are currently showing the same value, but I know from our runs that they should differ (the process skip count should not be higher than 0, because all items were processed) - the count column is always at 40

This might be, because I am using scdf 2.9.4 with the new ui, but I guess there were no changes made to this part of the ui.

image

Versions:

Spring Cloud Data Flow 2.9.4
Spring Cloud Task 2.4.2
Spring Cloud Data Flow UI 3.3.0-SNAPSHOT (current version of master branch without angular 14 commit)

@claudiahub / @oodamien have you time to look at this?

@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Jun 14, 2022
@oodamien
Copy link
Member

HI @klopfdreh,
Did you have a look on the API values?
I quickly checked the code UI, I didn't see any error so far.

@klopfdreh
Copy link
Contributor Author

klopfdreh commented Jun 14, 2022

@oodamien - the api is providing this values - it is an issue of spring cloud task or spring cloud data flow backend instead. Thanks for pointing me into this direction:

image

@oodamien oodamien transferred this issue from spring-cloud/spring-cloud-dataflow-ui Jun 14, 2022
@markpollack markpollack added this to the 2.9.5 milestone Jun 15, 2022
@markpollack markpollack added area/documentation Belongs to documentation and removed status/need-triage Team needs to triage and take a first look labels Jun 15, 2022
@klopfdreh
Copy link
Contributor Author

Hey @markpollack - I just wanted to ask why the label area/documentation was added - did I missed something or are the values correctly displayed? I was asking because our task did not skipped anything but showing up those values.

@cppwfs
Copy link
Contributor

cppwfs commented Jun 17, 2022

The first goal is to properly document the values present in the table. This will give a common vocabulary from which to ask questions or discuss changes in the calculations.
The skip values I will investigate.

@klopfdreh
Copy link
Contributor Author

Ah ok, that makes sense to me. Maybe it helps when I explain what I understand.

So for me and most cases there would be no requirement to differentiate between max / min / mean. Commit Count could be a single number how many items were committed for example. Good to know would be if there is a deviation and how may items are affected from the last run. So deviation would also be good to know in a column.

So all count values could be listed as tuple numbers. The actual count and the deviation from the last run.

The only exception is duration and duration per read. Duration per read to me is how long it took to read an item with a reader which in this case could be displayed with min / max / mean and deviation. Duration in general to me is the time it took to complete the whole step execution which could also could be displayed as min / max / mean.

So all in all I would split the information in addition to check if they are correct. (Which they aren’t in our case 😄 )

Hope this helps.

@markpollack markpollack added the status/need-investigation Oh need to look under a hood label Jun 21, 2022
@cppwfs
Copy link
Contributor

cppwfs commented Jun 24, 2022

Sorry for the delay in response.
The number of reads, writes, and commits can be viewed from the Job Executions Page as shown here:
image

As to the history Let's look at the example below:
image
In this example, we see that this job was run 4 times, and based on the flow, this step was executed 4 times (3 of which processed 6 records and one processed 20). Thus the changes in the min-max for the commits, reads, and writes. I agree that the count for each column is redundant based on how things are calculated and may be shown once at the top of the table.

I hope this helps.

@cppwfs cppwfs added status/need-feedback Calling participant to provide feedback and removed status/need-investigation Oh need to look under a hood labels Jun 24, 2022
@klopfdreh
Copy link
Contributor Author

I think to show it once at top of the table would be better and reduce the confusion about what the count belongs to.

@github-actions github-actions bot added for/team-attention For team attention and removed status/need-feedback Calling participant to provide feedback labels Jun 27, 2022
@cppwfs
Copy link
Contributor

cppwfs commented Jun 30, 2022

Added documentation for the Step History in the Data Flow Reference documentation.
Also created a story to deprecate the showing of counts for each column. It is enumerated here: #4971

@klopfdreh thank you for bringing this to our attention and writing up a good Issue.

@cppwfs cppwfs closed this as completed Jun 30, 2022
@github-actions github-actions bot added status/need-feedback Calling participant to provide feedback and removed for/team-attention For team attention labels Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Belongs to documentation status/need-feedback Calling participant to provide feedback
Projects
None yet
Development

No branches or pull requests

4 participants