Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all K8s-deployer properties show-up in the UI #368

Open
sabbyanandan opened this issue Mar 3, 2020 · 2 comments
Open

Not all K8s-deployer properties show-up in the UI #368

sabbyanandan opened this issue Mar 3, 2020 · 2 comments

Comments

@sabbyanandan
Copy link
Contributor

@sabbyanandan commented on Fri Feb 21 2020

As a user, while deploying a stream on Minikube, I am unable to override the createNodePort deployer property for the http-source because that option doesn't show up in the deployer properties dialog window.

image

NOTE: Depending on whether the fix is in the deployer, server, skipper, or UI, we may have to move this issue accordingly.

@sabbyanandan
Copy link
Contributor Author

Some notes from the internal discussion.

  1. Perhaps we could create a new @ConfigurationProperties class that fully represents the app-level property overrides, including createNodePort and others along with the same level.

  2. Maybe there's an opportunity to revise the global vs. app-level properties, to consolidate the infrastructure supported in the k8s-deployer for consistent overrides.

@chrisjs
Copy link
Contributor

chrisjs commented Mar 4, 2020

just a note; not specific to minikube in anyway and you can set this property, just may not be in whatever UI widgets (might have to enter manually in some text field). additionally shell always works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants