Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle 'zombie' services when deployment fails #450

Open
popadynetsb opened this issue Jun 3, 2021 · 0 comments
Open

How to handle 'zombie' services when deployment fails #450

popadynetsb opened this issue Jun 3, 2021 · 0 comments
Assignees
Labels
status/need-triage Team needs to triage and take a first look
Milestone

Comments

@popadynetsb
Copy link

Skipper creates a Service Object before the Deployment . As Skipper does not validate k8s Objects before trying to deploy an application and does not remove the service if the deployment fails, typos in a volume or volume mounts definitions result in zombie services. Now, on the next try, Skipper fails on deploying the service (as it is already present) and fixed component cannot be deployed

createService(request);
if (indexed) {
createStatefulSet(request);
}
else {
createDeployment(request);
}
return appId;

@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Jun 3, 2021
@markpollack markpollack added this to the 2.9.0-M1 milestone Oct 18, 2022
@markpollack markpollack changed the title Application deployment is no atomic How to handle 'zombie' services when deployment fails Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/need-triage Team needs to triage and take a first look
Projects
None yet
Development

No branches or pull requests

3 participants