Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring.cloud.deployer.kubernetes.[liveness | readiness]-command-probe-command is not working #535

Open
DebajitKumarPhukan opened this issue Mar 18, 2023 · 3 comments
Assignees
Labels
for/team-attention For team attention

Comments

@DebajitKumarPhukan
Copy link

Issue:
I have implemented a Spring Batch application which applies remote partitioning and launches jobs in Kubernetes. The issue I identified was that when I attempted for a command based readiness and liveness probe, it doesn't seem to be working at all. I verified the same in pod yaml and can't see any readiness/liveness probe generated at all. I can only see them passed under spec.containers.args in pod yaml.

Below are the configs I specified in the application.properties

spring.cloud.deployer.kubernetes.liveness-command-probe-command=echo live
spring.cloud.deployer.kubernetes.readiness-command-probe-command=echo live

I even tried setting below config with the hope that it would resolve the issue, but unfortunately it didn't.

spring.cloud.deployer.kubernetes.probe-type=command

@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Mar 18, 2023
@corneil
Copy link
Contributor

corneil commented Apr 4, 2023

The probe command has to an application not just shell command.

spring.cloud.deployer.kubernetes.liveness-command-probe-command='/bin/sh -c "echo live"'
spring.cloud.deployer.kubernetes.probe-type=COMMAND

@corneil corneil self-assigned this Apr 4, 2023
@corneil corneil added status/need-feedback Calling participant to provide feedback and removed status/need-triage Team needs to triage and take a first look labels Apr 5, 2023
@DebajitKumarPhukan
Copy link
Author

@corneil Hi, thanks for attending to this issue. I already tried all the possible combinations (including the ones you mentioned). The main issue here is that the pod yaml specifications generated don't have readiness or liveness specifications when probe-type = COMMAND and even if you specify liveness-command-probe-command or readiness-command-probe-command (in any ways).

@github-actions github-actions bot added for/team-attention For team attention and removed status/need-feedback Calling participant to provide feedback labels Apr 5, 2023
@DebajitKumarPhukan
Copy link
Author

@corneil Any updates ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for/team-attention For team attention
Projects
None yet
Development

No branches or pull requests

2 participants