Gateway MVC: Retry filter not supported with YAML configuration

[ah1508]

Describe the bug

Retry filter usage as described in the documentation (https://docs.spring.io/spring-cloud-gateway/reference/spring-cloud-gateway-server-mvc/filters/retry.html) does not work with spring-gateway-server-mvc 4.1 (spring-retry is in the classpath).

spring.cloud.gateway.mvc.routes:
    - id: foo-routing
      predicates:
        - Path=/foo/**
      uri: http://foo-api
      filters:
        - name: Retry
          args:
            retries: 3
            series: SERVER_ERROR
            methods: GET,POST

Error message: Unable to find operation interface org.springframework.web.servlet.function.HandlerFilterFunction for retry with args {retries=3, series=SERVER_ERROR, methods=GET,POST}

Last lines of the stacktrace

Caused by: java.lang.IllegalArgumentException: Unable to find operation interface org.springframework.web.servlet.function.HandlerFilterFunction for retry with args {retries=3, series=SERVER_ERROR, methods=GET,POST}
	at org.springframework.cloud.gateway.server.mvc.config.GatewayMvcPropertiesBeanDefinitionRegistrar.translate(GatewayMvcPropertiesBeanDefinitionRegistrar.java:252) ~[spring-cloud-gateway-server-mvc-4.1.0.jar:4.1.0]
	at org.springframework.cloud.gateway.server.mvc.config.GatewayMvcPropertiesBeanDefinitionRegistrar.lambda$getRouterFunction$6(GatewayMvcPropertiesBeanDefinitionRegistrar.java:232) ~[spring-cloud-gateway-server-mvc-4.1.0.jar:4.1.0]
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) ~[na:na]

The translate methods receives a MultiValueMap<String, OperationMethod> operations that contains 29 items, retry is not one of them:

[kristiyandimov19]

I have a similar issue, for me when creating a custom filter it works fine when using it as a @bean but when i try to configure it in application.yml it doesn't get picked up at all

[spencergibb]

@kristiyandimov19 yes, I need to document how to make custom filters and predicates available to config

Add @Shortcut to the static method

spring-cloud-gateway/spring-cloud-gateway-server-mvc/src/main/java/org/springframework/cloud/gateway/server/mvc/filter/FilterFunctions.java

Line 226 in 70b454e

@Shortcut

and then create a FilterSupplier

spring-cloud-gateway/spring-cloud-gateway-server-mvc/src/main/java/org/springframework/cloud/gateway/server/mvc/filter/FilterFunctions.java

Line 231 in 70b454e

class FilterSupplier implements org.springframework.cloud.gateway.server.mvc.filter.FilterSupplier {

and add it to spring.factories

spring-cloud-gateway/spring-cloud-gateway-server-mvc/src/main/resources/META-INF/spring.factories

Line 5 in 70b454e

org.springframework.cloud.gateway.server.mvc.filter.FilterFunctions.FilterSupplier

[kstueve1]

so I have to modify spring.factories. what happened to dependency injection

[spencergibb]

There's an enhancement request open to make it easier for developers.