Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make STRATEGY_KEY public in DedupeResonseHeader filter #3203

Closed
pengshizhong opened this issue Jan 2, 2024 · 0 comments · Fixed by #3300
Closed

Make STRATEGY_KEY public in DedupeResonseHeader filter #3203

pengshizhong opened this issue Jan 2, 2024 · 0 comments · Fixed by #3300
Labels
enhancement good first issue help wanted
Milestone
4.1.2

Comments

@pengshizhong
Copy link

image

All other filter configuration properties are of public type, but the properties of this class are private, which prevents me from referencing them when constructing routes programmatically.

I suggest adjusting this property to be of public type in future versions. Otherwise, users can only use this configuration name through hardcoding.
@anbusampath anbusampath mentioned this issue Mar 14, 2024
Merged
@spencergibb spencergibb added this to the 4.1.2 milestone Mar 14, 2024
@spencergibb spencergibb changed the title Why isn't this member variable of public type? Make STRATEGY_KEY public in DedupeResonseHeader filter Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
No open projects
2023.0.1
Status: Done
Milestone
4.1.2
Development

Successfully merging a pull request may close this issue.

make strategy key public anbusampath/spring-cloud-gateway
2 participants
@spencergibb @pengshizhong