Unable to set default filters via configuration properties

[fitzoh]

In M1 it does not appear to be possible to add a default filter via configuration properties.
Given the following configuration:

spring:
  cloud:
    gateway:
      default-filters:
       - name: filter1
       - name: filter2

with a breakpoint on GatewayProperties::getDefaultFilters I always end up with a single RemoveNonProxyHeadersWebFilterFactory filter which is added via GatewayProperties::loadDefaults.

I can verify that filter1 and filter2 are being created by setting breakpoints in the constructor.

[spencergibb]

This worked for me. Maybe a project that recreates the problem?

spring:
  cloud:
    gateway:
      default-filters:
      - name: AddResponseHeader
        args:
          name: X-Response-Default-Foo
          value: Default-Bar

[fitzoh]

Yeah, did a little more testing and it looks like you're correct.
I had a breakpoint set on the getter, and the getter was only getting called before the new values had been added to the bean. So the initial issue isn't valid, but I do still have a question if you don't mind....

What got me started down this thread was being unable to figure out why default filters weren't being applied to things from a RouteLocator bean.

Given:

@EnableGateway
@SpringBootApplication
public class SampleApplication {

    public static void main(String[] args) {
        SpringApplication.run(SampleApplication.class, args);
    }

    @Bean
    public RouteLocator routes() {
        return Routes.locator()
                .route("the-service")
                .uri("http://httpbin.org:80")
                .predicate(x -> true)
                .and()
                .build();
    }

}

public class ShutdownWebFilterFactory implements WebFilterFactory {

    @Override
    public WebFilter apply(Tuple args) {
        return (exchange, chain) -> {
            System.out.println("in filter, shutting down");
            System.exit(1);
            throw new RuntimeException();
        };

    }
}

spring:
  cloud:
    gateway:
      defaultFilters:
       - name: Shutdown

Why is the filter not being applied on every request?
Am I misunderstanding the purpose of defaultFilters?

sample project here
https://github.com/Fitzoh/spring-gateway-question

[spencergibb]

That is the purpose. ShutdownWebFilterFactory needs to be a bean.