This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Spring Cloud Config and Bus over Pub/Sub sample/docs #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1550 +/- ##
=========================================
Coverage 68.66% 68.66%
Complexity 1683 1683
=========================================
Files 244 244
Lines 6526 6526
Branches 662 662
=========================================
Hits 4481 4481
Misses 1754 1754
Partials 291 291
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1550 +/- ##
============================================
+ Coverage 68.58% 68.67% +0.09%
- Complexity 1692 1705 +13
============================================
Files 249 249
Lines 6601 6678 +77
Branches 667 676 +9
============================================
+ Hits 4527 4586 +59
- Misses 1778 1795 +17
- Partials 296 297 +1
Continue to review full report at Codecov.
|
artembilan
suggested changes
Mar 19, 2019
...cloud-gcp-pubsub-config-sample-client/src/main/java/com/example/PubSubConfigApplication.java
Outdated
Show resolved
Hide resolved
...s/spring-cloud-gcp-pubsub-config-sample/spring-cloud-gcp-pubsub-config-sample-server/pom.xml
Outdated
Show resolved
Hide resolved
...gcp-pubsub-config-sample-server/src/main/java/com/example/PubSubConfigServerApplication.java
Outdated
Show resolved
Hide resolved
meltsufin
suggested changes
Mar 19, 2019
There was a problem hiding this comment.
I feel like you have such good information in the sample. Maybe we can copy most of it into the refdoc as well?
Also, the naming of this feature is very confusing. Can we just call it "Spring Cloud Bus", or it's too generic to mean configuration management? From everything I've seen about Spring Cloud Bus, no one ever talks about anything but managing configuration with it.
spring-cloud-gcp-samples/spring-cloud-gcp-pubsub-config-sample/README.adoc
Outdated
Show resolved
Hide resolved
spring-cloud-gcp-samples/spring-cloud-gcp-pubsub-config-sample/README.adoc
Outdated
Show resolved
Hide resolved
spring-cloud-gcp-samples/spring-cloud-gcp-pubsub-config-sample/README.adoc
Outdated
Show resolved
Hide resolved
spring-cloud-gcp-samples/spring-cloud-gcp-pubsub-config-sample/README.adoc
Outdated
Show resolved
Hide resolved
spring-cloud-gcp-samples/spring-cloud-gcp-pubsub-config-sample/README.adoc
Outdated
Show resolved
Hide resolved
spring-cloud-gcp-samples/spring-cloud-gcp-pubsub-config-sample/README.adoc
Outdated
Show resolved
Hide resolved
spring-cloud-gcp-samples/spring-cloud-gcp-pubsub-config-sample/README.adoc
Outdated
Show resolved
Hide resolved
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # Fixed URLs ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * [ ] http://www.apache.org/licenses/ with 1 occurrences migrated to: https://www.apache.org/licenses/ ([https](https://www.apache.org/licenses/) result 200). * [ ] http://www.apache.org/licenses/LICENSE-2.0 with 504 occurrences migrated to: https://www.apache.org/licenses/LICENSE-2.0 ([https](https://www.apache.org/licenses/LICENSE-2.0) result 200).
…cloud-gcp into pubsub-cloud-config
Co-Authored-By: elefeint <41136058+elefeint@users.noreply.github.com>
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # HTTP URLs that Could Not Be Fixed These URLs were unable to be fixed. Please review them to see if they can be manually resolved. * [ ] http://xslthl.sourceforge.net/ (200) with 1 occurrences could not be migrated: ([https](https://xslthl.sourceforge.net/) result AnnotatedConnectException). # Fixed URLs ## Fixed But Review Recommended These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request or http redirected to an https URL, so they were migrated. Your review is recommended. * [ ] http://maven.apache.org/POM/4.0.0 (404) with 114 occurrences migrated to: https://maven.apache.org/POM/4.0.0 ([https](https://maven.apache.org/POM/4.0.0) result 404). ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * [ ] http://maven.apache.org/xsd/maven-4.0.0.xsd with 5 occurrences migrated to: https://maven.apache.org/xsd/maven-4.0.0.xsd ([https](https://maven.apache.org/xsd/maven-4.0.0.xsd) result 200). * [ ] http://www.w3.org/2001/XMLSchema-instance with 57 occurrences migrated to: https://www.w3.org/2001/XMLSchema-instance ([https](https://www.w3.org/2001/XMLSchema-instance) result 200).
artembilan
previously approved these changes
Mar 28, 2019
meltsufin
suggested changes
Mar 29, 2019
spring-cloud-gcp-samples/spring-cloud-gcp-pubsub-bus-config-sample/README.adoc
Outdated
Show resolved
Hide resolved
...gcp-pubsub-bus-config-sample/spring-cloud-gcp-pubsub-bus-config-sample-server-github/pom.xml
Outdated
Show resolved
Hide resolved
spring-cloud-gcp-samples/spring-cloud-gcp-pubsub-bus-config-sample/README.adoc
Outdated
Show resolved
Hide resolved
spring-cloud-gcp-samples/spring-cloud-gcp-pubsub-bus-config-sample/README.adoc
Outdated
Show resolved
Hide resolved
Co-Authored-By: elefeint <41136058+elefeint@users.noreply.github.com>
meltsufin
reviewed
Apr 1, 2019
| } | ||
| ---- | ||
|
|
||
| === Configuration Management with Spring Cloud Config |
There was a problem hiding this comment.
Isn't this Spring Cloud Config + Spring Cloud Bus?
Also, you don't really mention the Spring Cloud Stream binder for Pub/Sub.
All of the configuration for the Pub/Sub binder should apply here too, correct?
There was a problem hiding this comment.
Spring Cloud Bus is the top level header, but I'll add it here too for searchability.
For stream binder -- I mention it in the sample; I'll add here, too.
meltsufin
previously approved these changes
Apr 1, 2019
meltsufin
previously approved these changes
Apr 1, 2019
meltsufin
approved these changes
Apr 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Spring Cloud Bus integrates with Spring Cloud Stream, bus over Pub/Sub is already supported with our current
spring-cloud-stream-bindermodule.This PR contains a sample demonstrating storing configuration on a local file system, and storing it on GitHub (or any git repo, really).
There will be a follow up with a bit of custom code for supporting configuration change notifications from Cloud Source Repositories -- those would come over Pub/Sub instead of web hook invocation to
/monitor.