This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
PubsubTemplate subscribe in other projects #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change to the DefaultSubscriberFactory allows the project id of the
subscription to be overwitten directly from the subscription specification in the
subscription name string.
This allows use-cases like
pubSubTemplate.subscribe("projects/other-project/subscriptions/the-subscription",
messageReceiver).
This change is applied across the board to allow subscribing to,
creating, and deleting subscriptions using fully-qualified subscription names.
Fixes #1877.
Related to #1678.
Codecov Report
@@ Coverage Diff @@
## master #1880 +/- ##
============================================
+ Coverage 70.2% 71.57% +1.36%
- Complexity 1780 1817 +37
============================================
Files 236 236
Lines 6794 6706 -88
Branches 695 689 -6
============================================
+ Hits 4770 4800 +30
+ Misses 1705 1589 -116
+ Partials 319 317 -2
Continue to review full report at Codecov.
|
artembilan
suggested changes
Sep 12, 2019
| * @param subscriptionName the name of the new subscription | ||
| * @param topicName the name of the topic being subscribed to | ||
| * @param subscriptionName canonical subscription name, e.g., "subscriptionName", or the fully-qualified | ||
| * subscription name in the "projects/<project_name>/subscriptions/<subscription_name>" format |
There was a problem hiding this comment.
Can't we use {@code} instead?
| } | ||
|
|
||
| /** | ||
| * Creates a {@link ProjectSubscriptionName} based on a subscription name within a project or the |
There was a problem hiding this comment.
The method JavaDocs must be imperative - Create : https://github.com/spring-projects/spring-framework/wiki/Code-Style#javadoc-formatting
artembilan
suggested changes
Sep 12, 2019
| @@ -48,7 +48,8 @@ | |||
| * | |||
| * @deprecated as of 1.1, use {@link #subscribe(String, Consumer)} instead. | |||
There was a problem hiding this comment.
The @deprecated tag must be last one:
<module name="AtclauseOrder">
<property name="target" value="METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/>
<property name="tagOrder" value="@param, @return, @throws, @since, @deprecated, @see"/>
</module>
I'm not sure hot this passes a Checkstyle...
| @@ -98,7 +98,7 @@ public PubSubAdmin(GcpProjectIdProvider projectIdProvider, TopicAdminClient topi | |||
| * Create a new topic on Google Cloud Pub/Sub. | |||
| * | |||
| * @param topicName the name for the new topic within the current project, or the | |||
| * fully-qualified topic name in the projects/<project_name>/topics/<topic_name> format | |||
| * fully-qualified topic name in the {@code "projects/<project_name>/topics/<topic_name>"} format | |||
There was a problem hiding this comment.
Do we really need to that wrapped into double quotes?
artembilan
suggested changes
Sep 12, 2019
| @@ -48,7 +48,8 @@ | |||
| * | |||
| * @deprecated as of 1.1, use {@link #subscribe(String, Consumer)} instead. | |||
artembilan
approved these changes
Sep 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change to the DefaultSubscriberFactory allows the project id of the
subscription to be overwitten directly from the subscription specification in the
subscription name string.
This allows use-cases like
pubSubTemplate.subscribe("projects/other-project/subscriptions/the-subscription",
messageReceiver).
This change is applied across the board to allow subscribing to,
creating, and deleting subscriptions using fully-qualified subscription names.
Fixes #1877.
Related to #1678.