Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Pub/Sub Spring Cloud Stream binder should support ackMode customization #2079

Closed
elefeint opened this issue Dec 13, 2019 · 0 comments · Fixed by #2103
Closed

Pub/Sub Spring Cloud Stream binder should support ackMode customization #2079

elefeint opened this issue Dec 13, 2019 · 0 comments · Fixed by #2103
Assignees

Comments

@elefeint
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently stream binder creates a PubSubInboundChannelAdapter in default AUTO acknowlegement mode. As discussed in #2074, this does not allow a message to expire naturally -- a message will be acked in normal execution or in exception scenario where an error handler is declared, and a message will be nacked if an unhandled error occurs.

Describe the solution you'd like
Provide ability to override the PubSubInboundChannelAdapter ackMode property.

Describe alternatives you've considered
Another option discussed in original issue was to avoid raising an exception in AUTO_ACK and MANUAL modes. However, this would reduce the error handling flexibility, as it would eat the exception and provide no ability to recover its cause.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants