This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Firestore nested properties #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2300 +/- ##
============================================
- Coverage 80.95% 72.68% -8.28%
+ Complexity 2309 2063 -246
============================================
Files 258 258
Lines 7456 7464 +8
Branches 762 763 +1
============================================
- Hits 6036 5425 -611
- Misses 1100 1689 +589
- Partials 320 350 +30
Continue to review full report at Codecov.
|
meltsufin
suggested changes
Apr 2, 2020
| @@ -140,6 +140,9 @@ Spring Data generates a working implementation of the specified interface, which | |||
|
|
|||
| The `User` type parameter to `FirestoreReactiveRepository` refers to the underlying domain type. | |||
|
|
|||
| NOTE: `_` character can be used to refer to embedded properties. | |||
There was a problem hiding this comment.
You shouldn't need to use the underscore according to this:
https://docs.spring.io/spring-data/jpa/docs/current/reference/html/#repositories.query-methods.query-property-expressions
| @@ -170,6 +172,19 @@ public Object execute(Object[] parameters) { | |||
| return builder; | |||
| } | |||
|
|
|||
| private String getName(Part part) { | |||
| Iterator<PropertyPath> iterator = part.getProperty().iterator(); | |||
| Iterable<PropertyPath> iterable = () -> iterator; | |||
There was a problem hiding this comment.
combine these two lines into one?
...loud-gcp-data-firestore/src/test/java/org/springframework/cloud/gcp/data/firestore/User.java
Show resolved
Hide resolved
meltsufin
suggested changes
Apr 2, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2198