This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
support for nested properties in PartTree methods #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elefeint
previously requested changes
Apr 8, 2020
...va/org/springframework/cloud/gcp/data/datastore/repository/query/PartTreeDatastoreQuery.java
Outdated
Show resolved
Hide resolved
...va/org/springframework/cloud/gcp/data/datastore/repository/query/PartTreeDatastoreQuery.java
Outdated
Show resolved
Hide resolved
...va/org/springframework/cloud/gcp/data/datastore/repository/query/PartTreeDatastoreQuery.java
Outdated
Show resolved
Hide resolved
meltsufin
suggested changes
Apr 8, 2020
...va/org/springframework/cloud/gcp/data/datastore/repository/query/PartTreeDatastoreQuery.java
Outdated
Show resolved
Hide resolved
| DatastorePersistentProperty persistentProperty = (DatastorePersistentProperty) this.datastorePersistentEntity | ||
| .getPersistentProperty(part.getProperty().getSegment()); | ||
| Iterable<PropertyPath> iterable = () -> part.getProperty().iterator(); | ||
| List<DatastorePersistentProperty> properties = |
There was a problem hiding this comment.
Put this block into a separate helper private method buildName like you did for Firestore?
There was a problem hiding this comment.
here we need not only the name, but also the persistent property
Codecov Report
@@ Coverage Diff @@
## master #2307 +/- ##
============================================
- Coverage 80.97% 72.72% -8.26%
+ Complexity 2313 2065 -248
============================================
Files 258 258
Lines 7464 7471 +7
Branches 763 763
============================================
- Hits 6044 5433 -611
- Misses 1100 1689 +589
- Partials 320 349 +29
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
meltsufin
approved these changes
Apr 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2305