Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Allow projectId override in Firebase authentication #2405

Merged
merged 5 commits into from
Jun 3, 2020
Merged

Allow projectId override in Firebase authentication #2405

merged 5 commits into from
Jun 3, 2020

Conversation

femrtnz
Copy link
Contributor

@femrtnz femrtnz commented May 30, 2020

Hi All,

This is my first PR on spring-cloud. Please let me know if you have any questions or suggestions.

Fixes #2178, I'm enabling the project ID to be set on FirebaseAuthenticationProperties.java so you can use a different project ID

@codecov
Copy link

codecov bot commented May 30, 2020

Codecov Report

Merging #2405 into master will decrease coverage by 0.02%.
The diff coverage is 62.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2405      +/-   ##
============================================
- Coverage     74.00%   73.97%   -0.03%     
- Complexity     2108     2109       +1     
============================================
  Files           263      263              
  Lines          7604     7609       +5     
  Branches        787      788       +1     
============================================
+ Hits           5627     5629       +2     
- Misses         1614     1616       +2     
- Partials        363      364       +1     
Flag Coverage Δ Complexity Δ
#integration ? ?
#unittests 73.97% <62.50%> (-0.03%) 2109.00 <3.00> (+1.00) ⬇️
Impacted Files Coverage Δ Complexity Δ
...ure/security/FirebaseAuthenticationProperties.java 50.00% <33.33%> (-10.00%) 3.00 <1.00> (+1.00) ⬇️
...urity/FirebaseAuthenticationAutoConfiguration.java 92.85% <80.00%> (-7.15%) 5.00 <2.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff0d76...4e8fa8e. Read the comment docs.

Copy link
Contributor

@meltsufin meltsufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution again, @femrtnz!

@meltsufin meltsufin merged commit 428b910 into spring-attic:master Jun 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Allow projectId override in Firebase authentication
4 participants