-
Notifications
You must be signed in to change notification settings - Fork 695
Add maxMessages to PubSubReactiveFactory.poll #2441
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2441 +/- ##
============================================
+ Coverage 74.10% 74.14% +0.03%
- Complexity 2121 2123 +2
============================================
Files 264 264
Lines 7654 7657 +3
Branches 792 792
============================================
+ Hits 5672 5677 +5
+ Misses 1619 1617 -2
Partials 363 363
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the help! Your PR is very well done.
I'd like @meltsufin 's take tomorrow on how to acquire max messages; depending on the outcome you may either be able to merge this version (with a small validation change) or update the logic to accept maxMessages
as a constructor argument.
...ubsub/src/main/java/org/springframework/cloud/gcp/pubsub/reactive/PubSubReactiveFactory.java
Outdated
Show resolved
Hide resolved
...ubsub/src/main/java/org/springframework/cloud/gcp/pubsub/reactive/PubSubReactiveFactory.java
Outdated
Show resolved
Hide resolved
...ubsub/src/main/java/org/springframework/cloud/gcp/pubsub/reactive/PubSubReactiveFactory.java
Outdated
Show resolved
Hide resolved
@elefeint, @dzou, @meltsufin: thank you for the feedback. I have reverted my previous commit and added a new overloaded constructor for PubSubReactiveFactory that has maxMessages as a parameter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mturbe!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
As follow-up, I've filed #2451 to autoconfigure the new property. |
Fixes #2072