-
Notifications
You must be signed in to change notification settings - Fork 695
Added proxyBeanMethods = false to configuration classes for better GraalVM support #2525
Added proxyBeanMethods = false to configuration classes for better GraalVM support #2525
Conversation
…abac/spring-cloud-gcp into graalvm-proxybeanmethods-false * 'graalvm-proxybeanmethods-false' of https://github.com/gabac/spring-cloud-gcp: Added proxyBeanMethods = false to configuration classes. Fixes spring-attic#2524
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll have to make GcpCloudSqlAutoConfiguration and GcpStorageAutoConfiguration non-abstract for the tests to pass.
We've made them abstract to appease checkstyle, which no longer looks like a good tradeoff.
Thanks for the hint 👍 According to the https://github.com/spring-cloud/spring-cloud-gcp/blob/master/CONTRIBUTING.adoc I'm supposed to run
this is failing for me with:
|
Codecov Report
@@ Coverage Diff @@
## master #2525 +/- ##
=========================================
Coverage 74.27% 74.27%
Complexity 2162 2162
=========================================
Files 267 267
Lines 7760 7760
Branches 803 803
=========================================
Hits 5764 5764
Misses 1626 1626
Partials 370 370
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@gabac - No worries about it; we probably have to fix the instructions... Thanks for your contribution, looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to do this 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After adding in the master build fixes, this PR passes with flying colors.
Fixed #2524 and fixes #2500
I didn't change samples and test configurations.