This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
URL Cleanup #1551
Merged
URL Cleanup #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # HTTP URLs that Could Not Be Fixed These URLs were unable to be fixed. Please review them to see if they can be manually resolved. * http://xslthl.sf.net (301) with 1 occurrences could not be migrated: ([https](https://xslthl.sf.net) result AnnotatedConnectException). # Fixed URLs ## Fixed But Review Recommended These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request or http redirected to an https URL, so they were migrated. Your review is recommended. * http://www.puppycrawl.com/dtds/suppressions_1_1.dtd (404) with 1 occurrences migrated to: https://www.puppycrawl.com/dtds/suppressions_1_1.dtd ([https](https://www.puppycrawl.com/dtds/suppressions_1_1.dtd) result 404). ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * http://asciidoctor.org with 1 occurrences migrated to: https://asciidoctor.org ([https](https://asciidoctor.org) result 200). * http://sourceforge.net/projects/xslthl/ with 14 occurrences migrated to: https://sourceforge.net/projects/xslthl/ ([https](https://sourceforge.net/projects/xslthl/) result 200). * http://www.w3.org/TR/CSS21/propidx.html with 1 occurrences migrated to: https://www.w3.org/TR/CSS21/propidx.html ([https](https://www.w3.org/TR/CSS21/propidx.html) result 200). # Ignored These URLs were intentionally ignored. * http://maven.apache.org/POM/4.0.0 with 102 occurrences * http://www.w3.org/2001/XMLSchema-instance with 51 occurrences
Codecov Report
@@ Coverage Diff @@
## master #1551 +/- ##
=========================================
Coverage 68.66% 68.66%
Complexity 1683 1683
=========================================
Files 244 244
Lines 6526 6526
Branches 662 662
=========================================
Hits 4481 4481
Misses 1754 1754
Partials 291 291
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1551 +/- ##
=========================================
Coverage 68.66% 68.66%
Complexity 1683 1683
=========================================
Files 244 244
Lines 6526 6526
Branches 662 662
=========================================
Hits 4481 4481
Misses 1754 1754
Partials 291 291
Continue to review full report at Codecov.
|
It is better to use an https://checkstyle.org/dtds/suppressions_1_2.dtd
meltsufin
approved these changes
Mar 20, 2019
artembilan
approved these changes
Mar 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).
HTTP URLs that Could Not Be Fixed
These URLs were unable to be fixed. Please review them to see if they can be manually resolved.
(https result AnnotatedConnectException).
Fixed URLs
Fixed But Review Recommended
These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request or http redirected to an https URL, so they were migrated. Your review is recommended.
https://www.puppycrawl.com/dtds/suppressions_1_1.dtd (https result 404).
Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.
https://asciidoctor.org (https result 200).
https://sourceforge.net/projects/xslthl/ (https result 200).
https://www.w3.org/TR/CSS21/propidx.html (https result 200).
Ignored
These URLs were intentionally ignored.