Enable Connection Evictor in HttpClient (#4103) #4258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlgaMaciaszek
requested changes
Mar 25, 2024
There was a problem hiding this comment.
Hello @ZIRAKrezovic, thanks for the PR. Looks good. Have added some cosmetic comments. Also please document the idle timeout feature in docs/modules/ROOT/pages/spring-cloud-netflix.adoc.
...nt/src/main/java/org/springframework/cloud/netflix/eureka/RestTemplateTimeoutProperties.java
Show resolved
Hide resolved
...springframework/cloud/netflix/eureka/http/DefaultEurekaClientHttpRequestFactorySupplier.java
Show resolved
Hide resolved
|
Also, please add your full name and surname to the javadocs of any classes you've modified. |
|
Hi @OlgaMaciaszek, your feedback should be addressed. |
OlgaMaciaszek
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4103