New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spring boot server.compression conflict with feign.compression #229
Comments
Or default decoder should be able to handle gzip support with feign.compression.enabled=true. This would provide users minimum amount of gzip support for increased performance. |
Hi, @jskim1991 it makes sense to me to allowing gzip support (although not enforcing gzip decoding) when |
@OlgaMaciaszek Thank you for your feedback. In #145, you mentioned gzip support is not there because the default decoder(feign.codec.Decoder) from open-feign does not support it. However, when I checked the spring-cloud-openfeign, it actually has SpringDecoder which implements feign.codec.Decoder. So I think adding gzip support should be in spring-cloud-openfeign as well as openfeign. |
Sounds fine, @jskim1991 - could you create a PR? Please make sure that behaviour is optional and not default. |
If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed. |
I had the same issue as #145 .
I have the workaround or the fix to add the gzip decode support in default decoder.
Let me know if I can help to contribute.
Thanks,
The text was updated successfully, but these errors were encountered: