Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring boot server.compression conflict with feign.compression #229

Closed
jskim1991 opened this issue Oct 10, 2019 · 5 comments · Fixed by #230
Closed

spring boot server.compression conflict with feign.compression #229

jskim1991 opened this issue Oct 10, 2019 · 5 comments · Fixed by #230
Labels
enhancement New feature or request
Projects
Milestone

Comments

@jskim1991
Copy link
Contributor

I had the same issue as #145 .
I have the workaround or the fix to add the gzip decode support in default decoder.
Let me know if I can help to contribute.

Thanks,

@jskim1991
Copy link
Contributor Author

Or default decoder should be able to handle gzip support with feign.compression.enabled=true. This would provide users minimum amount of gzip support for increased performance.

@OlgaMaciaszek
Copy link
Collaborator

Hi, @jskim1991 it makes sense to me to allowing gzip support (although not enforcing gzip decoding) when feign.compression.enabled=true, but this is probably not specific to Spring Cloud Open Feign, so you should create an issue in OpenFeign repo instead.

@jskim1991
Copy link
Contributor Author

@OlgaMaciaszek Thank you for your feedback. In #145, you mentioned gzip support is not there because the default decoder(feign.codec.Decoder) from open-feign does not support it. However, when I checked the spring-cloud-openfeign, it actually has SpringDecoder which implements feign.codec.Decoder. So I think adding gzip support should be in spring-cloud-openfeign as well as openfeign.

@OlgaMaciaszek
Copy link
Collaborator

Sounds fine, @jskim1991 - could you create a PR? Please make sure that behaviour is optional and not default.

@OlgaMaciaszek OlgaMaciaszek added this to To do in Hoxton.RC1 via automation Oct 16, 2019
@OlgaMaciaszek OlgaMaciaszek added this to the 2.1.4.RELEASE milestone Oct 16, 2019
@OlgaMaciaszek OlgaMaciaszek added the enhancement New feature or request label Oct 16, 2019
@spring-projects-issues
Copy link

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

@ryanjbaxter ryanjbaxter added this to To do in Hoxton.RC2 via automation Oct 28, 2019
@ryanjbaxter ryanjbaxter removed this from To do in Hoxton.RC1 Oct 28, 2019
@ryanjbaxter ryanjbaxter modified the milestones: 2.1.4.RELEASE, 2.2.0.RC1 Oct 28, 2019
Hoxton.RC2 automation moved this from To do to Done Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Hoxton.RC2
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants