Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting Apache HC5.x #486

Closed
thanhj opened this issue Feb 17, 2021 · 3 comments · Fixed by #498
Closed

Supporting Apache HC5.x #486

thanhj opened this issue Feb 17, 2021 · 3 comments · Fixed by #498
Assignees
@OlgaMaciaszek
Labels
enhancement New feature or request
Projects
2020.0.2 Hoxton.SR11
Milestone
2.2.8.RELEASE

Comments

@thanhj
Copy link
Contributor

thanhj commented Feb 17, 2021 •
edited

Is your feature request related to a problem? Please describe.
The current version only supports Apache HC4.5.x and/or OkHttp.
Our team are using Spring-cloud-openfeign with Apache HC4.5.x, but we got into a performance issue when having a surge of high concurrent requests without enough connections in the ConnectionPool. The slow warming up connection in the pool is likely due to the global locking mechanism in PoolingHttpClientConnectionManager. And the Apache HC5.x is promising to solve that at least from its release notes.

Describe the solution you'd like
Replace HC4 by HC5 or add HC5 as another option.

Describe alternatives you've considered
A workaround solution I have considered is to manually declare HttpClient, but it is a lot of boilerplate codes.
@thanhj
Copy link
Contributor Author

thanhj commented Feb 18, 2021

By the way, do you have a the plan to support Async HttpClient yet?

@thanhj
Copy link
Contributor Author

thanhj commented Feb 20, 2021

This is a WIP PR for this request
#488

It would be great if someone can help here to finish the PR.

@OlgaMaciaszek OlgaMaciaszek self-assigned this Feb 22, 2021
@OlgaMaciaszek OlgaMaciaszek added this to To do in 2020.0.2 via automation Feb 25, 2021
@OlgaMaciaszek OlgaMaciaszek added this to To do in Hoxton.SR11 via automation Feb 25, 2021
@OlgaMaciaszek OlgaMaciaszek added this to the 2.2.8.RELEASE milestone Feb 25, 2021
@OlgaMaciaszek OlgaMaciaszek mentioned this issue Feb 25, 2021
Closed
@OlgaMaciaszek OlgaMaciaszek linked a pull request Feb 25, 2021 that will close this issue
Add apahce hc5 #488
Closed
@OlgaMaciaszek OlgaMaciaszek moved this from To do to In progress in 2020.0.2 Feb 25, 2021
@thanhj
Copy link
Contributor Author

thanhj commented Feb 28, 2021

#498

@OlgaMaciaszek OlgaMaciaszek moved this from To do to In progress in Hoxton.SR11 Mar 11, 2021
@OlgaMaciaszek OlgaMaciaszek mentioned this issue Mar 11, 2021
Merged
@OlgaMaciaszek OlgaMaciaszek linked a pull request Mar 11, 2021 that will close this issue
Add Apache HC5 client option #498
Merged
@OlgaMaciaszek OlgaMaciaszek moved this from In progress to Done in 2020.0.2 Mar 11, 2021
@OlgaMaciaszek OlgaMaciaszek moved this from In progress to Done in Hoxton.SR11 Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlgaMaciaszek OlgaMaciaszek

Labels
enhancement New feature or request
Projects
No open projects
2020.0.2
  
Done
Hoxton.SR11
  
Done
Milestone
2.2.8.RELEASE
3 participants
@OlgaMaciaszek @thanhj @spring-cloud-issues