Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NullpointerException in TraceFeignRetryer when using Retryer #362

Closed
thyzzv opened this issue Aug 2, 2016 · 3 comments
Closed

NullpointerException in TraceFeignRetryer when using Retryer #362

thyzzv opened this issue Aug 2, 2016 · 3 comments
Labels
Milestone

Comments

@thyzzv
Copy link

thyzzv commented Aug 2, 2016

I'm trying to implement a custom ErrorDecoder that forces a retry on a specific Errorcode.
While trying some options I run into a Nullpointer in TraceFeignRetryer

See thyzzv:sleuthspan-test latest master
Run the example "mvn spring-boot:run"

You will see:
java.lang.NullPointerException: null at org.springframework.cloud.sleuth.instrument.web.client.feign.TraceFeignRetryer.continueOrPropagate(TraceFeignRetryer.java:56) at feign.SynchronousMethodHandler.invoke(SynchronousMethodHandler.java:78) at feign.ReflectiveFeign$FeignInvocationHandler.invoke(ReflectiveFeign.java:103) at com.sun.proxy.$Proxy100.exp(Unknown Source) at net.test.sleuth.controllers.SleuthTestController.notOk(SleuthTestController.java:26) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

@marcingrzejszczak
Copy link
Contributor

I think it's high time to do this - #202 cc @spencergibb @adriancole . I'll have to sit down and think on how to add the pre and post process hooks to Feign

@marcingrzejszczak
Copy link
Contributor

Related PR - #367

@marcingrzejszczak
Copy link
Contributor

Should be fixed thanks to #372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants