Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct rel used for a collection resource after upgrade to SD REST 2.0.1 #1

Closed
odrotbohm opened this issue Feb 27, 2014 · 6 comments
Closed

Comments

@odrotbohm
Copy link

The guide discusses orders being used as rel in the _embedded section after data has been PUT to the server. However, this is a bug in Spring Data REST as it should be consistent with the customized resource rel in @RepositoryRestResource on PersonRepository.

I've filed and fixed DATAREST-261 so that we can tweak this once we shipped 2.0.1.

@gregturn
Copy link
Contributor

Where does this guide mention orders? I only see persons.

@odrotbohm
Copy link
Author

Sorry, I mixed this up: yes, the server lists persons in the collection resource representation after the PUT. But according to your configuration it should be people. It might be worthwhile to even simplify this to not showing @RepositoryRestResource at all and stick with the defaults.

@gregturn
Copy link
Contributor

Okay got it. The annotation seems simple enough to show how customizable it is. Some of the guides were initially drafted "too" simple to be unreasonable, so we made them a little more realistic. Really becomes a matter of taste I guess.

@odrotbohm
Copy link
Author

Whatever is fine for you? Maybe remove it for now to not expose the bug, and re-add it later on, when 2.0.1 has shipped? Simply waiting for 2.0.1 is perfectly fine as well, I think.

@gregturn
Copy link
Contributor

If 2.0.1 is coming soon, let's just leave it there with this issue open. Then we can wrap it up then.

@gregturn
Copy link
Contributor

Closed via 0230ae0, which brought the version of Spring Data REST up to 2.1.1.RELEASE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants