Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change gradle plugin #25

Closed
geoand opened this issue May 10, 2017 · 5 comments
Closed

Change gradle plugin #25

geoand opened this issue May 10, 2017 · 5 comments

Comments

@geoand
Copy link

geoand commented May 10, 2017

Hello everyone,

If I were to work on a PR in which I substituted the current gradle plugin for building docker images (Transmode/gradle-docker) with this one, is it likely it would be accepted?
The reason I believe such a change would be warranted is that the plugin used in the guide has not been updated in almost three years, while the one I propose seems to be far more active (latest release a couple months ago).

Looking forward to your feedback,
George

@gregturn
Copy link
Contributor

Transmode has changed as recent as March but I get your point that it may be stale showing few changes in the past year.

Checking out the other one, it appears to have a little of everything, which makes it unclear how well it's maintained. Have you used this for your own projects?

@geoand
Copy link
Author

geoand commented May 10, 2017

You are of course correct that Transmode has commits as late as March, it however doesn't have any releases since mid 2014.
Furthermore, besides the fact that the other project seems to have releases on regular intervals, it is being also maintained by Benjamin Muschko who actually works for Gradle (for what it's worth).

I have personally used it and seems to be working quite well (except for a bug during tagging images in the latest version, but the culprit in that case is docker-java, see this issue)

@gregturn
Copy link
Contributor

Okay sounds good. Thanks!

@geoand
Copy link
Author

geoand commented May 10, 2017 via email

@dsyer
Copy link
Contributor

dsyer commented Jan 6, 2020

We switched to jib.

@dsyer dsyer closed this as completed Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants