Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update this guide with Boot 2.3 features #84

Closed
philwebb opened this issue May 23, 2020 · 5 comments
Closed

Update this guide with Boot 2.3 features #84

philwebb opened this issue May 23, 2020 · 5 comments

Comments

@philwebb
Copy link
Contributor

No description provided.

@dsyer
Copy link
Contributor

dsyer commented May 28, 2020

Already done (over a week ago). Did you miss it, or did I do it wrong?

@dsyer dsyer closed this as completed Nov 2, 2020
@edudar
Copy link

edudar commented Dec 23, 2020

Could this be about buildpacks support? Packaging OCI Images paints quite a different picture with no Dockerfile in sight, for example.

@dsyer
Copy link
Contributor

dsyer commented Dec 24, 2020

What was “this” in your comment? The guide already has buildpack examples (and links to more detailed documentation like the one you mentioned). Maybe you have some ideas to make them more obvious?

@edudar
Copy link

edudar commented Dec 24, 2020

"This" just refers to this issue.

I think it might help to define options that developers have from the start as in Table of Content style. Something in the lines of "You can build nice and shiny spring boot image in the following ways: * dockerfile, * buildpacks using maven/gradle, * jib using its own plugins, * ..." and then expand each bullet point/option with more details. Because what may happen now, is that the developer goes through a tutorial that starts with a lengthy explanation of how to setup Dockerfile properly. They do it step by step. They end up with said Dockerfile and then, if careful, they might see that they didn't actually have to setup Dockerfile manually because there are other options. Or, as happened in my team, they will use bootBuildImage and Dockerfile together.

@dsyer
Copy link
Contributor

dsyer commented Dec 24, 2020

OK, that’s useful detail. How about opening a new issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants