Give priority to theme stored in localstorage #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore 'prefers-color-scheme' value if the theme is stored in local storage.
The change occurred automatically after 'npm install'.
|
@koyama-tagbangers Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@koyama-tagbangers Thank you for signing the Contributor License Agreement! |
philwebb
pushed a commit
that referenced
this pull request
Jun 10, 2021
Update `isInitialThemeDark` so that any value loaded from local-storage takes precedence. Prior to this commit, if the browser preferred the dark theme then the saved light theme would never be restored. See gh-23
philwebb
added a commit
that referenced
this pull request
Jun 10, 2021
* pr/23: Polish 'Fix dark scheme detect function' Fix dark scheme detect function Closes gh-23
|
Thanks for the fix and for signing the CLA. This has now been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix an issue applying dark mode forcely when
prefers-color-schemevalue is dark even thoughthemevalue is stored in localstorage.I change to use
prefers-color-schemevalue only ifthemevalue is not stored in localstorage or is an invalid value.