Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark/Light Mode Toggle + Restrictive Browser Permissions #50

Closed
mrg opened this issue May 21, 2021 · 0 comments
Closed

Dark/Light Mode Toggle + Restrictive Browser Permissions #50

mrg opened this issue May 21, 2021 · 0 comments
Milestone

Comments

@mrg
Copy link

mrg commented May 21, 2021

The dark/light mode toggle doesn't toggle between dark/light mode (although the toggle does animate) when you have more restrictive browser settings/permissions.

In my day-to-day browser, I whitelist which sites can write to local storage (similar for 3rd party cookies) and this seems to be the cause. When I try the site in my application-testing browser, which allows local storage, the dark/light mode toggle works and I can see "dark" and "light" values being written under the "theme" key.

@philwebb philwebb added this to the 0.0.x milestone May 25, 2021
@philwebb philwebb modified the milestones: 0.0.x, 0.0.2 Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants