Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reify batchGetAll into a CacheLevel #154

Closed
bkase opened this issue May 22, 2016 · 1 comment
Closed

Reify batchGetAll into a CacheLevel #154

bkase opened this issue May 22, 2016 · 1 comment
Labels
enhancement feature
Milestone
0.9

Comments

@bkase
Copy link
Contributor

bkase commented May 22, 2016

cache.allBatch().get(ks) is equivalent to cache.batchGetAll(ks), but the former allows for composition with other cache levels (something I needed)

Please advise on naming

Reifying batchGetSome will require adding a .some() function to PiedPiper in addition to .merge() which I would be happy to do if you feel it would be worth it.

Thanks!
@bkase bkase mentioned this issue May 23, 2016
Merged
@vittoriom
Copy link
Contributor

Hi @bkase, thanks for your contribution!
I like the idea of having a "BatchAll" CacheLevel rather than just the method as it is right now.

If you already know how to proceed with the Some counterpart, feel free to start working on it, I think it would be a good improvement to the API!

Thanks again, I'll have a look at the PR now

@vittoriom vittoriom added this to the 0.9 milestone May 23, 2016
This was referenced May 24, 2016
Closed
Closed
vittoriom added a commit that referenced this issue May 25, 2016
@vittoriom
Merge pull request #155 from bkase/batchallcache
5c12417 
#154: Reifies batchAllGet into a CacheLevel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement feature
Projects
None yet
Milestone
0.9
Development

No branches or pull requests
2 participants
@bkase @vittoriom