Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditions HasSpringBootDependencyImport don't recognise version property #411

Closed
ashakirin opened this issue Sep 19, 2022 · 0 comments · Fixed by #412
Closed

Conditions HasSpringBootDependencyImport don't recognise version property #411

ashakirin opened this issue Sep 19, 2022 · 0 comments · Fixed by #412
Labels
type: bug Something isn't working
Milestone

Comments

@ashakirin
Copy link
Contributor

ashakirin commented Sep 19, 2022

Condition HasSpringBootDependencyImport returns false for following pom:

                        <?xml version="1.0" encoding="UTF-8"?>
                        <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
                                 xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
                            <modelVersion>4.0.0</modelVersion>
                            <groupId>com.example</groupId>
                            <artifactId>explicit-deps-app</artifactId>
                            <version>0.0.1-SNAPSHOT</version>
                            <name>explicit-deps-app</name>
                            <description>explicit-deps-app</description>
                            <properties>
                                <spring-boot.version>2.7.1</spring-boot.version>
                            </properties>                                  
                            <dependencyManagement>
                                 <dependencies>
                                    <dependency>
                                        <groupId>org.springframework.boot</groupId>
                                        <artifactId>spring-boot-dependencies</artifactId>
                                        <version>${spring-boot.version}</version>
                                        <type>pom</type>
                                        <scope>import</scope>
                                    </dependency>
                                </dependencies>
                            </dependencyManagement>
                        </project>
@ashakirin ashakirin changed the title Conditions HasSpringBootDependencyImport and HasSpringBootDependencyManuallyManaged don't recognise version property Conditions HasSpringBootDependencyImport don't recognise version property Sep 19, 2022
@fabapp2 fabapp2 added the type: bug Something isn't working label Sep 26, 2022
@fabapp2 fabapp2 added this to the v0.12.0 milestone Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants