Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply initialize-spring-boot-migration on a Boot application might downgrade Boot version #453

Closed
fabapp2 opened this issue Sep 29, 2022 · 3 comments · Fixed by #779
Closed
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@fabapp2
Copy link
Collaborator

fabapp2 commented Sep 29, 2022

Describe the bug
Scanning the (see zip) Spring Boot application and applying initialize-spring-boot-migration downgrades the Spring Boot version from 2.7.4 to 2.7.3

To Reproduce
see above

Expected behavior
The version should be untouched if it is same or more recent than the declared version.

@fabapp2 fabapp2 added the type: bug Something isn't working label Sep 29, 2022
@sanagaraj-pivotal
Copy link
Contributor

demo.zip

Use this project to replicate the issue

@sanagaraj-pivotal
Copy link
Contributor

In the above project the condition to check if a project is a Spring app is by checking if the app uses SpringBootApplication Annotation in the project since the above project does not import appropriate jar SpringBootApplication Annotation was not resolved and hence SBM inferred that the project is not a spring project.

@fabapp2
Copy link
Collaborator Author

fabapp2 commented Sep 30, 2022

Hi @sanagaraj-pivotal
But the recipe (some action) downgrades the dependency, this should not happen imho.

@fabapp2 fabapp2 self-assigned this Oct 2, 2022
@fabapp2 fabapp2 added this to the v0.13.0 milestone Oct 18, 2022
@fabapp2 fabapp2 modified the milestones: v0.13.0, v0.14.0 Dec 1, 2022
@fabapp2 fabapp2 modified the milestones: v0.14.0, v0.15.0 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
2 participants