Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match OpenTelemetry core propagator functionality with baggage/traceparent #29

Closed
jkwatson opened this issue Mar 9, 2021 · 1 comment · Fixed by #31
Closed

Match OpenTelemetry core propagator functionality with baggage/traceparent #29

jkwatson opened this issue Mar 9, 2021 · 1 comment · Fixed by #31
Labels
bug Something isn't working
Milestone

Comments

@jkwatson
Copy link
Contributor

jkwatson commented Mar 9, 2021

Is your feature request related to a problem? Please describe.
The core OpenTelemetry W3C propagators operate completely independently of each other. That is, the W3CBaggagePropagator will extract baggage off the wire and put it into the Context, whether or not there is a valid Span in the incoming headers that could be extracted by the W3CTraceContextPropagator.

Currently the sleuth otel implementation will only provide Baggage in the context if there is also a valid Span in the traceparent header.

Describe the solution you'd like
It would be good to match the core OpenTelemetry functionality and be able to extract Baggage independently of whether or not there is a Span in the incoming payload.

@jkwatson
Copy link
Contributor Author

jkwatson commented Mar 9, 2021

Feel free to assign this to me, if y'all agree we should address it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants