Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

No need for FunctionalSpringApplication anymore #1120

Closed
sdeleuze opened this issue Oct 1, 2021 · 0 comments
Closed

No need for FunctionalSpringApplication anymore #1120

sdeleuze opened this issue Oct 1, 2021 · 0 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@sdeleuze
Copy link
Contributor

sdeleuze commented Oct 1, 2021

FunctionalSpringApplication does not seems to be compatible by design with the new AOT engine since it is doing a lot of infra initialization in ContextFunctionCatalogInitializer which is only invoked at runtime. What is done in ContextFunctionCatalogInitializer is hidden behind instance supplier so we can't really do something about it at buildtime.

Since the new AOT engine already generates an optimized ApplicationContextInitializer from the annotation programming model, I don't think FunctionalSpringApplication is still needed, the application can be developed as usual and will use ApplicationContextInitializer automatically at runtime.

@sdeleuze sdeleuze added the type: bug A general bug label Oct 1, 2021
@sdeleuze sdeleuze added this to the 0.11.0-M1 milestone Oct 1, 2021
@sdeleuze sdeleuze changed the title Fix cloud-function-netty-fun on native Remove cloud-function-netty-fun sample Oct 1, 2021
@sdeleuze sdeleuze added the type: task A general task label Oct 1, 2021
@sdeleuze sdeleuze self-assigned this Oct 1, 2021
@sdeleuze sdeleuze removed the type: bug A general bug label Oct 1, 2021
@sdeleuze sdeleuze added type: enhancement A general enhancement and removed type: task A general task labels Oct 1, 2021
@sdeleuze sdeleuze changed the title Remove cloud-function-netty-fun sample No need for FunctionalSpringApplication anymore Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement A general enhancement
Development

No branches or pull requests

1 participant