Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

Properly disable devtools in AOT mode #1419

Closed
sdeleuze opened this issue Jan 3, 2022 · 2 comments
Closed

Properly disable devtools in AOT mode #1419

sdeleuze opened this issue Jan 3, 2022 · 2 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@sdeleuze
Copy link
Contributor

sdeleuze commented Jan 3, 2022

As pointed out by @jamesward here, a build with the AOT plugin is broken when spring-boot-devtools is added.

The spirit of this commit was to say we don't enable AOT mode by default so you can use devtools and IDE integration by default.

As discussed with @bclozel we should probably:

  • Ignore the devtools dependency during the AOT generation
  • Remove the check that fails the build when devtools is detected
  • Document that devtools won't be active in AOT mode as it is not when the app is ran as a JAR
  • Maybe add a runtime warning log when devtools is detected when AOT mode is enabled
@sdeleuze sdeleuze added the type: enhancement A general enhancement label Jan 3, 2022
@sdeleuze sdeleuze added this to the 0.11.2 milestone Jan 3, 2022
@sdeleuze sdeleuze assigned bclozel and unassigned bclozel Jan 3, 2022
@sdeleuze sdeleuze changed the title Properly disable devtools is AOT mode. Properly disable devtools is AOT mode Jan 3, 2022
@spencergibb spencergibb changed the title Properly disable devtools is AOT mode Properly disable devtools in AOT mode Jan 3, 2022
@bclozel bclozel self-assigned this Jan 10, 2022
@jamesward
Copy link

I ran into this again when running: ./gradlew bootBuildImage

Execution failed for task ':generateAot'.
> Could not generate spring.factories source code

Removing developmentOnly("org.springframework.boot:spring-boot-devtools") gets it going again.

@sdeleuze
Copy link
Contributor Author

@jamesward I created #1579 related issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement A general enhancement
Development

No branches or pull requests

3 participants