Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

Fix com.mysql.cj.LocalizedErrorMessages errors on Petclinic samples #505

Closed
sdeleuze opened this issue Feb 24, 2021 · 3 comments
Closed
Assignees
Labels
type: regression A bug that is also a regression
Milestone

Comments

@sdeleuze
Copy link
Contributor

On petclinic-jpa and petclinic-jdbc, bundles defined in @nativeHint seems not taken in account by Spring AOP build plugin. This has been not detected because those samples were not correctly tested but thanks to @schauder it is now the case.

@sdeleuze sdeleuze added this to the 0.9.0 milestone Feb 24, 2021
@sdeleuze sdeleuze added the type: regression A bug that is also a regression label Feb 24, 2021
@aclement
Copy link
Contributor

I have a basically working fix, however due to side effects I have a bit more work to do. Registering the bundles is no big deal, however, GraalVM will hard fail if you ask for a bundle that isn't around. That means some of our hints that aren't quite correct cause samples to fail as bundles are registered that aren't around. (example, the webflux samples ask for the LocalStrings bundle that is only in webmvc samples). Shouldn't be too much work to sort it out.

I will mention when the bundle is working I then hit a missing proxy error for org.hibernate.query.spi.QueryImplementorwhich it looks like somebody needs to add.

@aclement
Copy link
Contributor

Changes are in. There are warnings in the output if hints lead to attempting to add bundles that won't work at native-image build time.

There is still the issue I eluded to about a missing proxy for QueryImplementor being reported (for petclinic-jpa) - maybe @schauder can take a look now I've unblocked it?

@sdeleuze
Copy link
Contributor Author

I fixed it with 4b65a68 @schauder feel free to update if you want to implement it differently.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: regression A bug that is also a regression
Development

No branches or pull requests

2 participants