Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

Conversation

kazuki43zoo
Copy link
Contributor

The current implementation occur the StackOverflowError when exists configuration properties bean that have cross reference property. I want to avoid the StackOverflowError.

Note: The properties class that provided by mybatis-spring-boot is this configuration (I understand it's not a good configuration..., but it's works on non-native Spring Boot).

@kazuki43zoo
Copy link
Contributor Author

Fixes #1404

@sdeleuze sdeleuze requested a review from snicoll January 3, 2022 18:09
@snicoll snicoll self-assigned this Jan 4, 2022
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 4, 2022
@snicoll snicoll added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 5, 2022
@snicoll snicoll added this to the 0.11.2 milestone Jan 5, 2022
@snicoll snicoll changed the title Avoid the StackOverflowError when exists cross reference configuration properties bean StackOverflowError when scanning hints for ConfigurationProperties with cross references Jan 5, 2022
@snicoll snicoll closed this in 3459117 Jan 5, 2022
@snicoll
Copy link
Contributor

snicoll commented Jan 5, 2022

@kazuki43zoo thank you for making your first contribution to Spring Native. I am impressed how you keep track of Mybatis-related issues and help fixing them, kudos!

I've polished your contribution as checking in the registry isn't an enough signal. Another component may have contributed some reflection hints for the type that is unrelated to configuration properties. See b264eae for more details.

@kazuki43zoo kazuki43zoo deleted the avoid-stackoverflow-when-exist-cross-reference-configuration-properties branch January 5, 2022 10:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug A general bug
Development

Successfully merging this pull request may close these issues.

None yet

3 participants