This repository has been archived by the owner on Feb 23, 2023. It is now read-only.
Reduce duplication of resources with basic regex cache #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems a reasonable change to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #524
This is a fairly basic check to avoid resources being duplicated twice in
resource-config.json- once through a generic regex such as"^templates/.*"and again through an individual entry for every file in src/main/resources. The approach is to build a compiled regex cache of any obvious patterns built in the initial contributor step, and test files against those. The logic to identify an actual regex pattern is fairly basic (patt.startsWith("^") && patt.endsWith(".*")) but worked well for my semi-complex project. It looks like onlyCommonWebInfosuses this approach at the moment but rather than just hardcode checks for templates/ and static/ I thought this approach might be a bit more future proof.Happy to consider an alternative approach.