This repository has been archived by the owner on Feb 23, 2023. It is now read-only.
Fix Spring Data custom repository fragment lookup. #661
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a
Substitution
for the Spring DataCustomRepositoryImplementationDetector
to directly use theCandidateComponentsIndex
for repository fragment lookups and adds the missing type hint for theRepositoryFragment
required to create the target repository.This enables fragments following the pattern
FragmentInterfaceName
|FragmentInterfaceNameImpl
to be discovered and registered correctly when annotated with@Component
as outlined below.It also updates the data-elasticsearch example to cover the custom repository setup and retains functionality of the heritage configuration format (used in the data-mongodb).
On the long run it would be beneficial to revisit the
ClassPathScanningCandidateComponentProvider
for bean lookups using thespring.components
index so it supports the in this PR substituted lookup.Closes: #639