Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListenerExecutionFailedException.getFailedMessage() is always null #535

Closed
OrangeDog opened this issue Jan 3, 2017 · 6 comments
Closed

ListenerExecutionFailedException.getFailedMessage() is always null #535

OrangeDog opened this issue Jan 3, 2017 · 6 comments

Comments

@OrangeDog
Copy link

It is my understanding that ErrorHandler and FatalExceptionStrategy are supposed to have access to the Message via the ListenerExecutionFailedException.

However, nothing ever appears to fill it in.
I would expect MessagingMessageListenerAdapter.invokeHandler to be passing it in the exception constructors.
@garyrussell
Copy link
Contributor

garyrussell commented Jan 3, 2017 •
edited

Yes; it's a bug; thanks for reporting; we will open a JIRA issue.

The older POJO adapter populates it, but not the @RabbitListener adapter.

@artembilan
Copy link
Member

See https://jira.spring.io/browse/AMQP-692

artembilan added a commit to artembilan/spring-amqp that referenced this issue Jan 3, 2017
@artembilan
AMQP-692: Fix MessagingMessageLA missed argument
9fae222 
JIRA: https://jira.spring.io/browse/AMQP-692
Fixes spring-projectsGH-535 (spring-projects#535)

The `ListenerExecutionFailedException` does not make sense without a `failedMessage`.
So, fix `MessagingMessageListenerAdapter` to use another `ListenerExecutionFailedException` ctor with the `amqpMessage` param as a `failedMessage` arg

**Cherry-pick to 1.6.x & 1.7.x**

Note: a `@Deprecated` ctor should be removed for `master`
@artembilan artembilan mentioned this issue Jan 3, 2017
Closed
garyrussell pushed a commit that referenced this issue Jan 3, 2017
@artembilan @garyrussell
AMQP-692: Fix MessagingMessageLA missed argument
a2691e3 
JIRA: https://jira.spring.io/browse/AMQP-692
Fixes GH-535 (#535)

The `ListenerExecutionFailedException` does not make sense without a `failedMessage`.
So, fix `MessagingMessageListenerAdapter` to use another `ListenerExecutionFailedException` ctor with the `amqpMessage` param as a `failedMessage` arg

**Cherry-pick to 1.6.x & 1.7.x**

Note: a `@Deprecated` ctor should be removed for `master`
garyrussell pushed a commit that referenced this issue Jan 3, 2017
@artembilan @garyrussell
AMQP-692: Fix MessagingMessageLA missed argument
c2394de 
JIRA: https://jira.spring.io/browse/AMQP-692
Fixes GH-535 (#535)

The `ListenerExecutionFailedException` does not make sense without a `failedMessage`.
So, fix `MessagingMessageListenerAdapter` to use another `ListenerExecutionFailedException` ctor with the `amqpMessage` param as a `failedMessage` arg

**Cherry-pick to 1.6.x & 1.7.x**

Note: a `@Deprecated` ctor should be removed for `master`
@OrangeDog
Copy link
Author

Is there a release plan for 1.6.7?

@garyrussell
Copy link
Contributor

It's not currently scheduled, but we can release it at any time if you need this fix urgently.

@garyrussell
Copy link
Contributor

The 1.7 GA is scheduled for Thursday next week; my preference would be to release 1.6.7 at the same time, if that would work for you.

@OrangeDog
Copy link
Author

Yes, the 19th should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

AMQP-692: Fix MessagingMessageLA missed argument artembilan/spring-amqp
3 participants
@garyrussell @OrangeDog @artembilan