-
Notifications
You must be signed in to change notification settings - Fork 265
Add a request factory based on okhttpclient #12
Conversation
Duplicate of ANDROID-138. Thanks for the pull request! |
@stephanenicolas have you signed the contributor agreement? I need this before I can accept code contribution. Thanks! |
I can' sign, your link is down. Do you have the txt that I should sign and S. 2014-08-05 3:27 GMT-07:00 Roy Clarkson notifications@github.com:
|
Hmm. That's strange, but it appears some of our internal people are looking into it already. For legal reasons, we have to use that form. But once you submit it, it's good forever and you can contribute to any of Spring's projects. I'll reply when it's working again. |
Thanks Roy. Waiting for it. S.
|
It appears the page is once again available. Thanks for your patience. |
Signed (#88520140805074516) Stéphane 2014-08-05 7:39 GMT-07:00 Roy Clarkson notifications@github.com:
|
Ok, thanks! I received a corresponding email with the details. |
My pleasure Roy. But If I may, I believe it would be more motivating for Stéphane 2014-08-05 8:00 GMT-07:00 Roy Clarkson notifications@github.com:
|
Yes, agreed. This project hasn't received the necessary attention over the last year. We're working to remedy that, and having active contributors would make a big difference. |
I've spent some time today working through the pull request. Take a look at this commit on my branch and let me know if you have any more feedback. I updated to OkHttp 2.0 in the process and did some formatting and cleanup. I'm concerned about creating a new |
I forgot to mention that I removed OkHttp as the default. I'd like to get feedback on its usage before making that change. But ultimately, I think it's probably the right move. |
I've merged my modifications of your pull request into master. Thanks, Stéphane! See commit 0e695e2bbacf1d1953e62dcb68905dac6545bd87 |
Hi @royclarkson , sorry for the delay. I reviewed the commit and it works fine for me. Thx to have merged this into Spring Android. |
See #24 about a problem with the current implementation of OkHttp factory (interceptors) |
Add a request factory based on okhttpclient if okhttpclient is available on the classpath. #10
This pull requests add very little code and provides an okhttp based implementation of spring android. This http engine has several advantages :
The pull requests is simple and is tested (thx to your tests).
I also updated the android maven plugin version to get things working with latest android SDK.