Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spring Security #6

Closed
rwinch opened this issue Apr 9, 2020 · 5 comments
Closed

Add Spring Security #6

rwinch opened this issue Apr 9, 2020 · 5 comments
Labels
status: duplicate A duplicate of another issue

Comments

@rwinch
Copy link
Member

rwinch commented Apr 9, 2020

This task will add Spring Security and ensure that all of the additional Filter's (gh-3, gh-5) are added to Spring Security in the proper places. We should start by using the existing Spring Security DSL (no need to create a custom DSL at this point).

@rwinch rwinch added this to the 0.0.1 milestone Apr 9, 2020
@rwinch rwinch changed the title Add Spring Security and ensure Filters Add Spring Security Apr 9, 2020
@jgrandja jgrandja added the type: enhancement A general enhancement label Apr 16, 2020
@pkostrzewa
Copy link

Once required filters from gh-3 and gh-5 will be finished can I take a look at this?

@jgrandja
Copy link
Collaborator

Thanks @pkostrzewa. The issue is yours.

@pkostrzewa
Copy link

As gh-3 and gh-5 were closed I can progress with this issue.

@jgrandja Could you please provide a detailed description with requirements? Similar to the one available for gh-5.

@jgrandja
Copy link
Collaborator

jgrandja commented Jun 3, 2020

@pkostrzewa This issue would simply modify the SecurityConfig in the minimal sample by http.addFilterAfter() (or http.addFilterBefore() the ClientCredentialsAuthenticationFilter (in sample) and OAuth2TokenEndpointFilter (in core).

In addition, a test should demonstrate the client obtaining the access token via the client_credentials grant.

@jgrandja
Copy link
Collaborator

This is no longer needed as a result of gh-25 and commit 5927475

@jgrandja jgrandja removed this from the 0.0.1 milestone Aug 19, 2020
@jgrandja jgrandja added status: duplicate A duplicate of another issue and removed type: enhancement A general enhancement labels Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

4 participants