Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lines To skip not working properly #56

Closed
naabbas opened this issue Jun 9, 2020 · 1 comment
Closed

Lines To skip not working properly #56

naabbas opened this issue Jun 9, 2020 · 1 comment

Comments

@naabbas
Copy link

naabbas commented Jun 9, 2020

For POI Item Reader API if initial rows are null and we have applied linesToSkip it will skip those many lines but once it finds rows with not null values it will pick number of columns from row 0. Which should not be the case . It should pick that row column numbers.

//PoiSheet
@OverRide
public int getNumberOfColumns() {
if (numberOfColumns < 0) {
numberOfColumns = this.delegate.getRow(0).getLastCellNum();
}
return numberOfColumns;
}

@mdeinum
Copy link
Collaborator

mdeinum commented Mar 29, 2021

This code has been removed since and we always use the current row to determine the column count. Closing this as it became obsolete.

Closed with #65.

@mdeinum mdeinum closed this as completed Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants