Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SSL termination in servlet container #101

Closed
camechis opened this issue Oct 31, 2013 · 7 comments
Closed

Support for SSL termination in servlet container #101

camechis opened this issue Oct 31, 2013 · 7 comments
Labels
type: enhancement A general enhancement

Comments

@camechis
Copy link

Not sure if its already supported but I need the ability to configure Mutual SSL Authentication in Jetty/Tomcat.

@camechis camechis reopened this Oct 31, 2013
@dsyer
Copy link
Member

dsyer commented Oct 31, 2013

Can you provide some more detail or a pull request, please? You want the container to terminate SSL?

@camechis
Copy link
Author

Sorry if I wasn't clear. Spring Security supports X509 Auth and I may be
wrong here but I believe there are some configurations that need to be done
to the container( Jetty/Tomcat ) in order for it to work. I just wasnt'
sure if spring-boot has these settings configurable since the containers
are embedded. For instance Dropwizard allows you to do this with its YAML
configuration.

http:
   connectorType: nonblocking+ssl
   ssl:
       keyStore: foo.jks
       keyStorePassword: "asfasf"
       trustStore: bar.jks
       trustStorePassword: "asfasf"
       wantClientAuth: true
       needClientAuth: true

@dsyer
Copy link
Member

dsyer commented Oct 31, 2013

I see. That makes sense (enabling SSL termination in the container). I don't think that would be very difficult. Pull requests welcome.

@dsyer
Copy link
Member

dsyer commented Nov 29, 2013

I added some documentation based on doing this yourself in a TomcatConnectorCustomizer (see https://github.com/spring-projects/spring-boot/blob/master/docs/howto.md)

@dsyer dsyer closed this as completed Nov 29, 2013
@btiernay
Copy link

Would be nice if this could be done declaratively a la Dropwizard. This is one area where Dropwizard has the edge over boot imho, and there aren't many of those :)

@philwebb
Copy link
Member

@ btiernay I've raised a new enhancement request issue for this. /cc yourself to #1084 .

@btiernay
Copy link

@philwebb Thats awesome. You guys rock :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants