Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binding failure with cloned arrays #12478

Closed
snicoll opened this issue Mar 14, 2018 · 1 comment
Closed

Binding failure with cloned arrays #12478

snicoll opened this issue Mar 14, 2018 · 1 comment
Assignees
Labels
type: regression A regression from a previous release
Milestone

Comments

@snicoll
Copy link
Member

snicoll commented Mar 14, 2018

This sample reproduces the issue raised on SO.

Binding works fine if the array isn't cloned and breaks when it is.

@snicoll snicoll added type: regression A regression from a previous release priority: normal labels Mar 14, 2018
@snicoll snicoll added this to the 2.0.1 milestone Mar 14, 2018
@mbhave
Copy link
Contributor

mbhave commented Mar 14, 2018

If there is a bound value, the AggregateBinder tries to get the existing value so that it can merge that with the bound value. The getter in the sample throws a NPE since this.urls is null.

For Array types the merge just returns the bound value so getting the existing value is unnecessary. Maybe if we skip this get for Array types this will work.

@mbhave mbhave self-assigned this Mar 15, 2018
@mbhave mbhave closed this as completed in 9384e5c Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression A regression from a previous release
Projects
None yet
Development

No branches or pull requests

2 participants