Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework WebMvcMetricsFilter to be general purpose with tech strategies #13064

Closed
philwebb opened this issue May 4, 2018 · 6 comments
Closed

Rework WebMvcMetricsFilter to be general purpose with tech strategies #13064

philwebb opened this issue May 4, 2018 · 6 comments
Labels
status: superseded An issue that has been superseded by another

Comments

@philwebb
Copy link
Member

philwebb commented May 4, 2018

The WebMvcMetricsFilter is currently tied to Spring MVC but we'd also like to support Jersey and possibly general servlets. We could rework WebMvcMetricsFilter to MetricsFilter that provides the general code and create new technology specific strategies that can extract tags based on a specific technology.
@philwebb philwebb added this to the Backlog milestone May 4, 2018
@philwebb philwebb added the type: enhancement A general enhancement label May 4, 2018
@philwebb philwebb mentioned this issue May 4, 2018
Closed
@wilkinsona wilkinsona mentioned this issue May 4, 2018
Closed
@wilkinsona wilkinsona changed the title Rework WebMvcMetricsFilter to be general purspose with tech strategies Rework WebMvcMetricsFilter to be general purpose with tech strategies May 11, 2018
@wilkinsona wilkinsona mentioned this issue Jun 14, 2018
Open
@philwebb philwebb modified the milestones: 2.1.x, 2.x Sep 11, 2018
@philwebb philwebb modified the milestones: 2.x, 2.2.x Jan 14, 2019
@haykart

This comment has been minimized.

Sign in to view
@wilkinsona

This comment has been minimized.

Sign in to view
@philwebb philwebb modified the milestones: 2.2.x, 2.x Apr 19, 2019
@jkuipers

This comment has been minimized.

Sign in to view
@philwebb

This comment has been minimized.

Sign in to view
@jkuipers jkuipers mentioned this issue Jun 14, 2019
Closed
@jkuipers
Copy link

@jkuipers That sounds like something we should address regardless. Do you by any chance have a small sample project that you could attach to a new issue?

I just created #17147 with a demo project.

@philwebb philwebb mentioned this issue Jan 12, 2022
Closed
@philwebb philwebb mentioned this issue Jan 20, 2022
Closed
@philwebb philwebb modified the milestones: 2.x, 3.x Aug 19, 2022
@bclozel bclozel removed this from the 3.x milestone Apr 15, 2024
@bclozel bclozel added status: superseded An issue that has been superseded by another and removed type: enhancement A general enhancement labels Apr 15, 2024
@bclozel
Copy link
Member

bclozel commented Apr 15, 2024

In the meantime, the observability support has been rewritten entirely and Jersey/MVC instrumentations are independent. Jersey apps should not depend on the web starter and as a result, the web layer will not be instrumented twice. Closing with #39294 (comment)

@bclozel bclozel closed this as not planned Won't fix, can't repro, duplicate, stale Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jkuipers @bclozel @philwebb @wilkinsona @haykart