Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Kotlin metadata to retrieve parameter names of Endpoints #16199

Open
snicoll opened this issue Mar 11, 2019 · 1 comment
Open

Use Kotlin metadata to retrieve parameter names of Endpoints #16199

snicoll opened this issue Mar 11, 2019 · 1 comment
Labels
type: enhancement A general enhancement
Milestone

Comments

@snicoll
Copy link
Member

snicoll commented Mar 11, 2019

Thanks to @sdeleuze I was able to improve the logic to extract parameters name of @ConfigurationProperties constructors with Kotlin. This results in a simpler setup for Kotlin users as they don't have to specify the java-parameters attribute on the compiler.

We're currently documenting that this is required but that's not strictly necessary so I wonder if we shouldn't apply the same trick there as well. We could then stop using the flag ourselves in our test suites to validate that this is working as expected (this would require some Kotlin-specific tests though).

@snicoll snicoll added for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Mar 11, 2019
@sdeleuze
Copy link
Contributor

+1, java-parameters is not an attribute commonly used in Kotlin since this information is already available via Kotlin reflection.

@snicoll snicoll added type: enhancement A general enhancement and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Mar 13, 2019
@snicoll snicoll modified the milestones: 2.2.x, 2.x Mar 13, 2019
@philwebb philwebb modified the milestones: 2.x, 3.x Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants