Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore indentation in published spring-boot-dependencies and spring-boot-starter-parent poms #16466

Closed
KingBuzzer opened this issue Apr 5, 2019 · 7 comments
Labels
type: task A general task
Milestone

Comments

@KingBuzzer
Copy link

The POMs in 2.1.4 lost all formatting/indentation which makes them harder to read.

Examples:

2.1.3 is using 4 spaces indentation:
https://search.maven.org/remotecontent?filepath=org/springframework/boot/spring-boot-dependencies/2.1.3.RELEASE/spring-boot-dependencies-2.1.3.RELEASE.pom

2.1.4 is using no indentation
https://search.maven.org/remotecontent?filepath=org/springframework/boot/spring-boot-dependencies/2.1.4.RELEASE/spring-boot-dependencies-2.1.4.RELEASE.pom

No biggie of course :-) Thanks for a great framework!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 5, 2019
@wilkinsona
Copy link
Member

Thanks for spotting this, it wasn't intentional. The good news is that the indentation is missing in the snapshot repo (for example https://repo.spring.io/snapshot/org/springframework/boot/spring-boot-dependencies/2.1.5.BUILD-SNAPSHOT/spring-boot-dependencies-2.1.5.BUILD-SNAPSHOT.pom), so the indentation is being lost somewhere that should be in our control, rather than on the way to Maven Central.

@wilkinsona wilkinsona added this to the 2.1.x milestone Apr 5, 2019
@wilkinsona wilkinsona added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 5, 2019
@songxinqiang
Copy link

By the way, i found in <artifactId>spring-boot</artifactId> use 2 spaces to indentation,but in <artifactId>spring-boot-dependencies</artifactId> use 4 spaces to indentation.
Can we use 4 space in all pom files?

@wilkinsona
Copy link
Member

@songxinqiang Where did you find this difference?

@wilkinsona
Copy link
Member

Curiously, the problem doesn't seem to affect every pom. For example, the pom for spring-boot is fine (https://repo.spring.io/snapshot/org/springframework/boot/spring-boot/2.1.5.BUILD-SNAPSHOT/spring-boot-2.1.5.BUILD-SNAPSHOT.pom).

@wilkinsona
Copy link
Member

I think I see what @songxinqiang was getting at. In 2.1.3, spring-boot is indented with 2 spaces but spring-boot-dependencies is indented with 4 spaces. In 2.1.4, spring-boot is still indented with 2 spaces but spring-boot-dependencies is no longer indented.

@wilkinsona wilkinsona changed the title 2.1.4 POMs has not indentation anymore. Restore indentation in published spring-boot-dependencies pom Apr 15, 2019
@wilkinsona wilkinsona modified the milestones: 2.1.x, 2.1.5 Apr 15, 2019
@philwebb philwebb reopened this Apr 15, 2019
@philwebb
Copy link
Member

philwebb commented Apr 15, 2019

We have another one of these in spring-boot-starter-parent that currently uses 4.

@songxinqiang
Copy link

I think I see what @songxinqiang was getting at. In 2.1.3, spring-boot is indented with 2 spaces but spring-boot-dependencies is indented with 4 spaces. In 2.1.4, spring-boot is still indented with 2 spaces but spring-boot-dependencies is no longer indented.

yeah, I found a different number of indented spaces in different files.

@wilkinsona wilkinsona changed the title Restore indentation in published spring-boot-dependencies pom Restore indentation in published spring-boot-dependencies and spring-boot-starter-parent poms Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

5 participants