Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LogMessage.format when possible #16543

Open
philwebb opened this issue Apr 11, 2019 · 2 comments
Open

Use LogMessage.format when possible #16543

philwebb opened this issue Apr 11, 2019 · 2 comments
Labels
status: pending-design-work Needs design work before any code can be developed type: task A general task
Milestone
3.x

Comments

@philwebb
Copy link
Member

Spring Framework has introduced a nice LogMessage class that we might be able to use in a few placed to reduce the need for isWarnEnabled etc.
@philwebb philwebb added the type: task A general task label Apr 11, 2019
@philwebb philwebb added this to the 2.x milestone Apr 11, 2019
@pkostrzewa
Copy link
Contributor

Can I work on this one?

@philwebb
Copy link
Member Author

@pkostrzewa Thanks for the offer, but the changes are likely to require some careful review (it's not necessary to change all log messages). I really just added the issue as a placeholder for something we'll look at after 2.2.

@philwebb philwebb added the status: pending-design-work Needs design work before any code can be developed label Apr 16, 2019
@philwebb philwebb modified the milestones: 2.x, 3.x Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: pending-design-work Needs design work before any code can be developed type: task A general task
Projects
None yet
Milestone
3.x
Development

No branches or pull requests
2 participants
@philwebb @pkostrzewa