Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review messages used in Assert calls #17521

Open
philwebb opened this issue Jul 15, 2019 · 2 comments
Open

Review messages used in Assert calls #17521

philwebb opened this issue Jul 15, 2019 · 2 comments
Labels
type: task A general task
Milestone

Comments

@philwebb
Copy link
Member

philwebb commented Jul 15, 2019

Currently we tend to call assert with message like this:

Assert.notNull(fooBar, "FooBar must not be null");

Framework actually uses two different styles of message which mean slightly different things. A message "FooBar must not be null" refers to a type called FooBar. A message "'fooBar' must not be null" refers to the parameter or property name and is used when there is no useful explicit type.

@philwebb philwebb added the type: task A general task label Jul 15, 2019
@philwebb philwebb added this to the 2.2.x milestone Jul 15, 2019
@philwebb philwebb added the for: team-attention An issue we'd like other members of the team to review label Jul 15, 2019
@philwebb philwebb modified the milestones: 2.2.x, 2.x Jul 17, 2019
@philwebb philwebb removed the for: team-attention An issue we'd like other members of the team to review label Jul 17, 2019
@jjsfernandez
Copy link

Hi @philwebb, can i work on this issue?

@philwebb
Copy link
Member Author

Sorry for the late reply @JosejeSinohui. This one is likely to touch a lot of files so I think it's best if one of the core team take care of it since we'll need to coordinate around other work.

@philwebb philwebb modified the milestones: 2.x, 3.x Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

2 participants