Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UndertowReactiveWebServerFactory has DeploymentInfoCustomizers even though it does not create a DeploymentInfo #17555

Closed
wilkinsona opened this issue Jul 17, 2019 · 0 comments
Closed

UndertowReactiveWebServerFactory has DeploymentInfoCustomizers even though it does not create a DeploymentInfo #17555

wilkinsona opened this issue Jul 17, 2019 · 0 comments
Assignees
@wilkinsona
Labels
type: bug A general bug
Milestone
2.1.7

Comments

@wilkinsona
Copy link
Member

UndertowReactiveWebServerFactory has DeploymentInfoCustomizers but never does anything with them as it does not create a DeploymentInfo. Not creating a DeploymentInfo makes sense as it's a Servlet-specific concept. We should deprecate the methods for adding and getting the customizers and then remove them in due course.
@wilkinsona wilkinsona added the type: bug A general bug label Jul 17, 2019
@wilkinsona wilkinsona added this to the 2.1.x milestone Jul 17, 2019
@wilkinsona wilkinsona added for: team-attention An issue we'd like other members of the team to review and removed for: team-attention An issue we'd like other members of the team to review labels Jul 17, 2019
@wilkinsona wilkinsona self-assigned this Jul 17, 2019
@wilkinsona wilkinsona mentioned this issue Jul 17, 2019
Closed
@wilkinsona wilkinsona modified the milestones: 2.1.x, 2.1.7 Jul 18, 2019
@istonikula istonikula mentioned this issue Jan 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: bug A general bug
Projects
None yet
Milestone
2.1.7
Development

No branches or pull requests
1 participant
@wilkinsona