Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate @Import classes to use constructor injection #18231

Open
philwebb opened this issue Sep 13, 2019 · 2 comments
Open

Migrate @Import classes to use constructor injection #18231

philwebb opened this issue Sep 13, 2019 · 2 comments
Labels
type: task A general task
Milestone
3.x

Comments

@philwebb
Copy link
Member

See spring-projects/spring-framework#23637

We may have a few *Aware based implementation that we can migrate.
@philwebb philwebb added this to the 2.2.x milestone Sep 13, 2019
@philwebb philwebb added the type: task A general task label Sep 13, 2019
@wilkinsona
Copy link
Member

Some classes in the public API are potentially affected and I'm not sure how we should handle them. AbstractRepositoryConfigurationSourceSupport is one interesting example. If we change it to use constructor injection, all of its sub-classes will have to change too. Previously, they were unaware of their super-class's use of ResourceLoader, BeanFactory, and Environment.

@wilkinsona wilkinsona added the for: team-attention An issue we'd like other members of the team to review label Sep 17, 2019
@philwebb
Copy link
Member Author

philwebb commented Sep 17, 2019 •
edited

Interesting, I guess those might be better left as they are.

@philwebb philwebb removed the for: team-attention An issue we'd like other members of the team to review label Sep 18, 2019
@philwebb philwebb modified the milestones: 2.2.x, 2.x Sep 20, 2019
@philwebb philwebb modified the milestones: 2.x, 3.x Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
3.x
Development

No branches or pull requests
2 participants
@philwebb @wilkinsona