Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools does not correctly handle encoded URLs found in the Class-Path manifest attribute #18410

Closed
testforstephen opened this issue Sep 29, 2019 · 0 comments
Assignees
Labels
type: bug A general bug
Milestone

Comments

@testforstephen
Copy link

testforstephen commented Sep 29, 2019

Environment:
spring-boot 2.1.6.RELEASE

Steps to Reproduce:

  1. Download spring-petclinic project into a parent path with white space. e.g. C:/empty space
  2. Open it in VS Code (installed vscode-java-pack extension)
  3. Changed the console option in launch.json to integratedTerminal
  4. Run the spring-petclinic project, and the integrated terminal will show a message at the begining.
    The Class-Path manifest attribute in C:\Users\jinbwan\AppData\Local\Temp\cp_4bwsd8d4n0k0fxz6uwwaduweu.jar referenced one or more files that do not exist: file:/C:/Work/Debugger/Bug_Cases/empty%20space/spring-petclinic/target/classes/

Background:
VS Code Java Debugger extension will generate the classpath args into a classpath.jar. And it uses absolute path in classpath.jar, and encode them as URL. When the classpath has white space, it will get the error message above. But if i moved spring-petclinic to a normal folder without whitespace, it works well.

So this looks like a corner case not covered.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 29, 2019
@wilkinsona wilkinsona changed the title Stop the message 'The Class-Path manifest attribute ... not exist' when using MANIFEST jar DevTools does not correctly handle encoded URLs found in the Class-Path manifest attribute Oct 3, 2019
@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 3, 2019
@wilkinsona wilkinsona added this to the 2.1.x milestone Oct 3, 2019
@wilkinsona wilkinsona self-assigned this Oct 3, 2019
@wilkinsona wilkinsona modified the milestones: 2.1.x, 2.1.10 Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

3 participants